Use jsdelivr as a CDN to fix broken links#3459
Merged
raclim merged 1 commit intoprocessing:developfrom Apr 18, 2025
Merged
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
raclim
approved these changes
Apr 18, 2025
Collaborator
raclim
left a comment
There was a problem hiding this comment.
Thanks for confirming and updating the links, I'll push this out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #3457 we noticed that some CDN links were broken, and changed the version back to 1.11.3.
It seems that this is a cloudflare CDN issue, with them not updating especially quickly when we release a new version. In the past we switched to jsdelivr as our CDN on the p5.js website as they seem to update much more quickly. I had started using jsdelivr URLs in the version picker here too, but only when you start to change the version -- the default was using Cloudflare as before. So a possible solution is to just use jsdelivr as the default.
Changes:
The p5 version in the default sketch seems to work now!
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123